-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-20671 B-20674 B-20758 simulate process TPPS cmd MAIN #13624
B-20671 B-20674 B-20758 simulate process TPPS cmd MAIN #13624
Conversation
…im trailing whitespace pre commit hook
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How dare you make me go through so many commits on several different PRs. Exhausting and it ain't even 8am!
LGTM!
Thank you for suffering through it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all changes are there when looking at the INT PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
INT PR
This is the combined branch for the three backlog items regarding TPPS as well as the additional work to be able to test it with the simulate-process-tpps binary. This branch was used to conduct testing/PO acceptance to Dan yesterday, with attachments showing the testing process on B-20671 and B-20758.
Important
The commented out code in process_edis.go and gex_sftp.go will be uncommented in B-20560, with gov PO approval. Commenting out that code out will allow us to push this code to staging/prod without seeing errors in the logs while we wait on the final TPPS SFTP directory. Added to Agility here and here.